Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 954c736f authored by Amir Goldstein's avatar Amir Goldstein Committed by Miklos Szeredi
Browse files

ovl: fix may_write_real() for overlayfs directories 



Overlayfs directory file_inode() is the overlay inode whether the real
inode is upper or lower.

This fixes a regression in xfstest generic/158.

Fixes: 7c6893e3 ("ovl: don't allow writing ioctl on lower layer")
Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
parent 9e66317d

fs/namespace.c

+3 −1
Original line number Diff line number Diff line
@@ -468,7 +468,9 @@ static inline int may_write_real(struct file *file) 


	/* File refers to upper, writable layer? */

	upperdentry = d_real(dentry, NULL, 0, D_REAL_UPPER);

	if (upperdentry && file_inode(file) == d_inode(upperdentry))

	if (upperdentry &&

	    (file_inode(file) == d_inode(upperdentry) ||

	     file_inode(file) == d_inode(dentry)))

		return 0;



	/* Lower layer: can't write to real file, sorry... */