Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 945315b9 authored by Takuya Yoshikawa's avatar Takuya Yoshikawa Committed by Marcelo Tosatti
Browse files

KVM: MMU: Use list_for_each_entry_safe in kvm_mmu_commit_zap_page() 



We are traversing the linked list, invalid_list, deleting each entry by
kvm_mmu_free_page().  _safe version is there for such a case.

Reviewed-by: default avatarGleb Natapov <gleb@redhat.com>
Signed-off-by: default avatarTakuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>
Signed-off-by: default avatarMarcelo Tosatti <mtosatti@redhat.com>
parent 1044b030

arch/x86/kvm/mmu.c

+3 −4
Original line number Diff line number Diff line
@@ -2087,7 +2087,7 @@ static int kvm_mmu_prepare_zap_page(struct kvm *kvm, struct kvm_mmu_page *sp, 
static void kvm_mmu_commit_zap_page(struct kvm *kvm,

				    struct list_head *invalid_list)

{

	struct kvm_mmu_page *sp;

	struct kvm_mmu_page *sp, *nsp;



	if (list_empty(invalid_list))

		return;
@@ -2104,11 +2104,10 @@ static void kvm_mmu_commit_zap_page(struct kvm *kvm, 
	 */

	kvm_flush_remote_tlbs(kvm);



	do {

		sp = list_first_entry(invalid_list, struct kvm_mmu_page, link);

	list_for_each_entry_safe(sp, nsp, invalid_list, link) {

		WARN_ON(!sp->role.invalid || sp->root_count);

		kvm_mmu_free_page(sp);

	} while (!list_empty(invalid_list));

	}

}



/*