Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 93c76dbb authored by Bart Van Assche's avatar Bart Van Assche Committed by Doug Ledford
Browse files

IB/srp: Document locking conventions 



Use lockdep_assert_held() statements to verify at run-time
whether the proper locks are held.

Signed-off-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
Cc: Israel Rukshin <israelr@mellanox.com>
Cc: Max Gurtovoy <maxg@mellanox.com>
Cc: Laurence Oberman <loberman@redhat.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 0a6fdbde

drivers/infiniband/ulp/srp/ib_srp.c

+5 −0
Original line number Diff line number Diff line
@@ -40,6 +40,7 @@ 
#include <linux/parser.h>

#include <linux/random.h>

#include <linux/jiffies.h>

#include <linux/lockdep.h>

#include <rdma/ib_cache.h>



#include <linux/atomic.h>
@@ -1799,6 +1800,8 @@ static struct srp_iu *__srp_get_tx_iu(struct srp_rdma_ch *ch, 
	s32 rsv = (iu_type == SRP_IU_TSK_MGMT) ? 0 : SRP_TSK_MGMT_SQ_SIZE;

	struct srp_iu *iu;



	lockdep_assert_held(&ch->lock);



	ib_process_cq_direct(ch->send_cq, -1);



	if (list_empty(&ch->free_tx))
@@ -1829,6 +1832,8 @@ static void srp_send_done(struct ib_cq *cq, struct ib_wc *wc) 
		return;

	}



	lockdep_assert_held(&ch->lock);



	list_add(&iu->list, &ch->free_tx);

}