Commit 931dfa69 authored Oct 13, 2015 by Dan Carpenter Committed by Mark Brown Oct 22, 2015

ASoC: wm8904: harmless underflow in wm8904_put_deemph()



We try to check that "deemph" is zero or one, but because of an
underflow bug, it can also be negative.  It's fine, negative values are
handled as non-zero.  But it's messy and static checkers complain so
let's fix it.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 6ff33f39

sound/soc/codecs/wm8904.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -534,7 +534,7 @@ static int wm8904_put_deemph(struct snd_kcontrol *kcontrol,
		{
		struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
		struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);
		int deemph = ucontrol->value.integer.value[0];
		unsigned int deemph = ucontrol->value.integer.value[0];

		if (deemph > 1)
		return -EINVAL;