Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 92d30a93 authored by Jiri Slaby's avatar Jiri Slaby Committed by Linus Torvalds
Browse files

Char: moxa, remove useless tty functions 



- moxa_flush_chars -- no code; ldics handle this well
- moxa_put_char -- only wrapper to moxa_write (same code), tty does this
  the same way if tty->driver->put_char is NULL

Signed-off-by: default avatarJiri Slaby <jirislaby@gmail.com>
Tested-by: default avatarOyvind Aabling <Oyvind.Aabling@uni-c.dk>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent eaa95a8d

drivers/char/moxa.c

+0 −25
Original line number Diff line number Diff line
@@ -193,8 +193,6 @@ static int moxa_write(struct tty_struct *, const unsigned char *, int); 
static int moxa_write_room(struct tty_struct *);

static void moxa_flush_buffer(struct tty_struct *);

static int moxa_chars_in_buffer(struct tty_struct *);

static void moxa_flush_chars(struct tty_struct *);

static void moxa_put_char(struct tty_struct *, unsigned char);

static void moxa_throttle(struct tty_struct *);

static void moxa_unthrottle(struct tty_struct *);

static void moxa_set_termios(struct tty_struct *, struct ktermios *);
@@ -391,8 +389,6 @@ static const struct tty_operations moxa_ops = { 
	.write_room = moxa_write_room,

	.flush_buffer = moxa_flush_buffer,

	.chars_in_buffer = moxa_chars_in_buffer,

	.flush_chars = moxa_flush_chars,

	.put_char = moxa_put_char,

	.ioctl = moxa_ioctl,

	.throttle = moxa_throttle,

	.unthrottle = moxa_unthrottle,
@@ -1284,27 +1280,6 @@ static int moxa_chars_in_buffer(struct tty_struct *tty) 
	return chars;

}



static void moxa_flush_chars(struct tty_struct *tty)

{

	/*

	 * Don't think I need this, because this is called to empty the TX

	 * buffer for the 16450, 16550, etc.

	 */

}



static void moxa_put_char(struct tty_struct *tty, unsigned char c)

{

	struct moxa_port *ch = tty->driver_data;



	if (ch == NULL)

		return;

	spin_lock_bh(&moxa_lock);

	MoxaPortWriteData(ch, &c, 1);

	spin_unlock_bh(&moxa_lock);



	ch->statusflags |= LOWWAIT;

}



static int moxa_tiocmget(struct tty_struct *tty, struct file *file)

{

	struct moxa_port *ch;