Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 91bff997 authored by Ram Amrani's avatar Ram Amrani Committed by Doug Ledford
Browse files

RDMA/qedr: Remove CQ spinlock from CM completion handlers 



There is only a single event queue that triggers the completion
events for the RDMA CM and it is being processed serially. This means
that inherently there can no parallelism of CQ completion handler
callbacks, hence the lock is redundant.

Signed-off-by: default avatarRam Amrani <Ram.Amrani@cavium.com>
Signed-off-by: default avatarMichal Kalderon <Michal.Kalderon@cavium.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 59e8970b

drivers/infiniband/hw/qedr/qedr.h

+0 −3
Original line number Diff line number Diff line
@@ -251,9 +251,6 @@ struct qedr_cq { 


	u16 icid;



	/* Lock to protect completion handler */

	spinlock_t comp_handler_lock;



	/* Lock to protect multiplem CQ's */

	spinlock_t cq_lock;

	u8 arm_flags;

drivers/infiniband/hw/qedr/qedr_cm.c

+2 −8
Original line number Diff line number Diff line
@@ -87,11 +87,8 @@ void qedr_ll2_tx_cb(void *_qdev, struct qed_roce_ll2_packet *pkt) 
	qedr_inc_sw_gsi_cons(&qp->sq);

	spin_unlock_irqrestore(&qp->q_lock, flags);



	if (cq->ibcq.comp_handler) {

		spin_lock_irqsave(&cq->comp_handler_lock, flags);

	if (cq->ibcq.comp_handler)

		(*cq->ibcq.comp_handler) (&cq->ibcq, cq->ibcq.cq_context);

		spin_unlock_irqrestore(&cq->comp_handler_lock, flags);

	}

}



void qedr_ll2_rx_cb(void *_dev, struct qed_roce_ll2_packet *pkt,
@@ -113,11 +110,8 @@ void qedr_ll2_rx_cb(void *_dev, struct qed_roce_ll2_packet *pkt, 


	spin_unlock_irqrestore(&qp->q_lock, flags);



	if (cq->ibcq.comp_handler) {

		spin_lock_irqsave(&cq->comp_handler_lock, flags);

	if (cq->ibcq.comp_handler)

		(*cq->ibcq.comp_handler) (&cq->ibcq, cq->ibcq.cq_context);

		spin_unlock_irqrestore(&cq->comp_handler_lock, flags);

	}

}



static void qedr_destroy_gsi_cq(struct qedr_dev *dev,