Commit 9149916f authored Aug 23, 2017 by Subhransu S. Prusty Committed by Mark Brown Aug 23, 2017

ASoC: Intel: Skylake: Fix uninitialized return

On failure to get dsp_ops, dsp_init returns error without assigning ret. ret
is assigned in code path which will never be executed. Fix it.

Fixes: f77d443c ("ASoC: Intel: Skylake: Fix to free resources for dsp_init failure"
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 7b992c24

sound/soc/intel/skylake/skl-messages.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -278,8 +278,8 @@ int skl_init_dsp(struct skl *skl)

		ops = skl_get_dsp_ops(skl->pci->device);
		if (!ops) {
		goto unmap_mmio;
		ret = -EIO;
		goto unmap_mmio;
		}

		loader_ops = ops->loader_ops();