Commit 90d4fa45 authored Sep 17, 2017 by Richard Weinberger Committed by Cyrille Pitchen Oct 10, 2017

mtd: spi-nor: Kill check with no effect



header.minor is of type u8 and cannot be negative.

Detected by CoverityScan CID#1417858 ("Integer handling issues")

Fixes: f384b352 ("mtd: spi-nor: parse Serial Flash Discoverable
Parameters (SFDP) tables")
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>

parent 8a5776a5

drivers/mtd/spi-nor/spi-nor.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -2288,8 +2288,7 @@ static int spi_nor_parse_sfdp(struct spi_nor *nor,

		/* Check the SFDP header version. */
		if (le32_to_cpu(header.signature) != SFDP_SIGNATURE \|\|
		header.major != SFDP_JESD216_MAJOR \|\|
		header.minor < SFDP_JESD216_MINOR)
		header.major != SFDP_JESD216_MAJOR)
		return -EINVAL;

		/*