Commit 9092f46b authored May 18, 2005 by John W. Linville Committed by Jeff Garzik May 24, 2005

[PATCH] tulip: add return to ULI526X clause in tulip_mdio_write



The 'if' clause for ULI526X in tulip_mdio_write allows for
spin_unlock_irqrestore to be called twice for tp->mii_lock.  I believe
this is caused by the unintentional omission of a return at the end
of that clause.  This patch adds that return.

Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 187a1a94

drivers/net/tulip/media.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -174,6 +174,7 @@ void tulip_mdio_write(struct net_device *dev, int phy_id, int location, int val)
		break;
		}
		spin_unlock_irqrestore(&tp->mii_lock, flags);
		return;
		}

		/* Establish sync by sending 32 logic ones. */