Commit 8fe78989 authored Oct 28, 2014 by Zoltan Kiss Committed by David S. Miller Oct 29, 2014

xen-netback: Disable NAPI after disabling interrupts



Otherwise the interrupt handler still calls napi_complete. Although it
won't schedule NAPI again as either NAPI_STATE_DISABLE or
NAPI_STATE_SCHED is set, it is just unnecessary, and it makes more
sense to do this way.

Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7fd2561e

drivers/net/xen-netback/interface.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -281,10 +281,10 @@ static void xenvif_down(struct xenvif *vif)

		for (queue_index = 0; queue_index < num_queues; ++queue_index) {
		queue = &vif->queues[queue_index];
		napi_disable(&queue->napi);
		disable_irq(queue->tx_irq);
		if (queue->tx_irq != queue->rx_irq)
		disable_irq(queue->rx_irq);
		napi_disable(&queue->napi);
		del_timer_sync(&queue->credit_timeout);
		}
		}