Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8f6fc8d4 authored by Quinn Tran's avatar Quinn Tran Committed by Nicholas Bellinger
Browse files

qla2xxx: Fix inadequate lock protection for ABTS. 



Normally, ABTS is sent to Target Core as Task MGMT command.
In the case of error, qla2xxx needs to send response, hardware_lock
is required to prevent request queue corruption.

Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarQuinn Tran <quinn.tran@cavium.com>
Signed-off-by: default avatarHimanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 8b666809

drivers/scsi/qla2xxx/qla_target.c

+10 −2
Original line number Diff line number Diff line
@@ -130,6 +130,9 @@ static void qlt_send_term_imm_notif(struct scsi_qla_host *vha, 
static struct fc_port *qlt_create_sess(struct scsi_qla_host *vha,

	fc_port_t *fcport, bool local);

void qlt_unreg_sess(struct fc_port *sess);

static void qlt_24xx_handle_abts(struct scsi_qla_host *,

	struct abts_recv_from_24xx *);



/*

 * Global Variables

 */
@@ -389,6 +392,8 @@ static bool qlt_24xx_atio_pkt_all_vps(struct scsi_qla_host *vha, 
			(struct abts_recv_from_24xx *)atio;

		struct scsi_qla_host *host = qlt_find_host_by_vp_idx(vha,

			entry->vp_index);

		unsigned long flags;



		if (unlikely(!host)) {

			ql_dbg(ql_dbg_tgt, vha, 0xffff,

			    "qla_target(%d): Response pkt (ABTS_RECV_24XX) "
@@ -396,9 +401,12 @@ static bool qlt_24xx_atio_pkt_all_vps(struct scsi_qla_host *vha, 
			    vha->vp_idx, entry->vp_index);

			break;

		}

		qlt_response_pkt(host, (response_t *)atio);

		if (!ha_locked)

			spin_lock_irqsave(&host->hw->hardware_lock, flags);

		qlt_24xx_handle_abts(host, (struct abts_recv_from_24xx *)atio);

		if (!ha_locked)

			spin_unlock_irqrestore(&host->hw->hardware_lock, flags);

		break;



	}



	/* case PUREX_IOCB_TYPE: ql2xmvasynctoatio */