Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8f536b87 authored by Felix Fietkau's avatar Felix Fietkau Committed by John W. Linville
Browse files

ath9k: simplify ath_tid_drain 



ath_tid_drain is only called when a station entry is being removed, so
there is no point in still tracking BAW state. Remove some unnecessary
code and a bogus TODO comment related to this.

Signed-off-by: default avatarFelix Fietkau <nbd@openwrt.org>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent a1c781bb

drivers/net/wireless/ath/ath9k/xmit.c

+0 −12
Original line number Diff line number Diff line
@@ -312,12 +312,6 @@ static void ath_tx_addto_baw(struct ath_softc *sc, struct ath_atx_tid *tid, 
	}

}



/*

 * TODO: For frame(s) that are in the retry state, we will reuse the

 * sequence number(s) without setting the retry bit. The

 * alternative is to give up on these and BAR the receiver's window

 * forward.

 */

static void ath_tid_drain(struct ath_softc *sc, struct ath_txq *txq,

			  struct ath_atx_tid *tid)
@@ -341,14 +335,8 @@ static void ath_tid_drain(struct ath_softc *sc, struct ath_txq *txq, 
		}



		list_add_tail(&bf->list, &bf_head);



		ath_tx_update_baw(sc, tid, bf->bf_state.seqno);

		ath_tx_complete_buf(sc, bf, txq, &bf_head, &ts, 0);

	}



	tid->seq_next = tid->seq_start;

	tid->baw_tail = tid->baw_head;

	tid->bar_index = -1;

}



static void ath_tx_set_retry(struct ath_softc *sc, struct ath_txq *txq,