Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8ea6cdf5 authored by Peter Senna Tschudin's avatar Peter Senna Tschudin Committed by Greg Kroah-Hartman
Browse files

staging: et131x: Remove useless return variables 



This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.

Verified by compilation only.

The coccinelle script that find and fixes this issue is:
// <smpl>
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// </smpl>

Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Acked-by: default avatarMark Einon <mark.einon@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 43b54cc9

drivers/staging/et131x/et131x.c

+1 −2
Original line number Diff line number Diff line
@@ -4237,7 +4237,6 @@ static int et131x_ioctl(struct net_device *netdev, struct ifreq *reqbuf, 
static int et131x_set_packet_filter(struct et131x_adapter *adapter)

{

	int filter = adapter->packet_filter;

	int status = 0;

	u32 ctrl;

	u32 pf_ctrl;
@@ -4288,7 +4287,7 @@ static int et131x_set_packet_filter(struct et131x_adapter *adapter) 
		writel(pf_ctrl, &adapter->regs->rxmac.pf_ctrl);

		writel(ctrl, &adapter->regs->rxmac.ctrl);

	}

	return status;

	return 0;

}



/* et131x_multicast - The handler to configure multicasting on the interface */