Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8e025ae2 authored by Yuval Mintz's avatar Yuval Mintz Committed by David S. Miller
Browse files

qede: Don't report link change needlessly 



There are several corner cases where driver might get a 2nd notification
about the same link change. Don't log any additional changes if the
physical carrier is already reported as it should.

Signed-off-by: default avatarYuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b1199b10

drivers/net/ethernet/qlogic/qede/qede_main.c

+10 −6
Original line number Diff line number Diff line
@@ -2780,15 +2780,19 @@ static void qede_link_update(void *dev, struct qed_link_output *link) 
	}



	if (link->link_up) {

		if (!netif_carrier_ok(edev->ndev)) {

			DP_NOTICE(edev, "Link is up\n");

			netif_tx_start_all_queues(edev->ndev);

			netif_carrier_on(edev->ndev);

		}

	} else {

		if (netif_carrier_ok(edev->ndev)) {

			DP_NOTICE(edev, "Link is down\n");

			netif_tx_disable(edev->ndev);

			netif_carrier_off(edev->ndev);

		}

	}

}



static int qede_set_mac_addr(struct net_device *ndev, void *p)

{