Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8daedea6 authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds
Browse files

parport_pc locking fix 

http://bugzilla.kernel.org/show_bug.cgi?id=8821

 reports a might_sleep()
warning due to parport_pc_exit() running platform_device_unregister() while
holding ports_lock.

Just remove the locking: nobody else can access ports_list during module_exit.

Cc: "Mike Sharkey" <mike@pikeaero.com>
Cc: Tim Waugh <tim@cyberelk.net>
Cc: Stas Sergeev <stsp@aknet.ru>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent c21b37f6

drivers/parport/parport_pc.c

+0 −4
Original line number Diff line number Diff line
@@ -3445,7 +3445,6 @@ static void __exit parport_pc_exit(void) 
		pnp_unregister_driver (&parport_pc_pnp_driver);

	platform_driver_unregister(&parport_pc_platform_driver);



	spin_lock(&ports_lock);

	while (!list_empty(&ports_list)) {

		struct parport_pc_private *priv;

		struct parport *port;
@@ -3455,11 +3454,8 @@ static void __exit parport_pc_exit(void) 
		if (port->dev && port->dev->bus == &platform_bus_type)

			platform_device_unregister(

				to_platform_device(port->dev));

		spin_unlock(&ports_lock);

		parport_pc_unregister_port(port);

		spin_lock(&ports_lock);

	}

	spin_unlock(&ports_lock);

}



MODULE_AUTHOR("Phil Blundell, Tim Waugh, others");