Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 8d6fb0bc authored by Arvind Yadav's avatar Arvind Yadav Committed by Mark Brown
Browse files

ASoC: ep93xx-ac97: Fix platform_get_irq's error checking 



The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: default avatarArvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 4fbd8d19

sound/soc/cirrus/ep93xx-ac97.c

+3 −3
Original line number Original line Diff line number Diff line
@@ -365,7 +365,7 @@ static int ep93xx_ac97_probe(struct platform_device *pdev) 
{

{

	struct ep93xx_ac97_info *info;

	struct ep93xx_ac97_info *info;

	struct resource *res;

	struct resource *res;

	unsigned int irq;

	int irq;

	int ret;

	int ret;





	info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);

	info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);
@@ -378,8 +378,8 @@ static int ep93xx_ac97_probe(struct platform_device *pdev) 
		return PTR_ERR(info->regs);

		return PTR_ERR(info->regs);





	irq = platform_get_irq(pdev, 0);

	irq = platform_get_irq(pdev, 0);

	if (!irq)

	if (irq <= 0)

		return -ENODEV;

		return irq < 0 ? irq : -ENODEV;





	ret = devm_request_irq(&pdev->dev, irq, ep93xx_ac97_interrupt,

	ret = devm_request_irq(&pdev->dev, irq, ep93xx_ac97_interrupt,

			       IRQF_TRIGGER_HIGH, pdev->name, info);

			       IRQF_TRIGGER_HIGH, pdev->name, info);