Commit 8d263be8 authored Aug 03, 2016 by Daniel Wagner Committed by Wolfram Sang Aug 15, 2016

i2c: bcm-iproc: Use complete() instead of complete_all()



There is only one waiter for the completion, therefore there
is no need to use complete_all(). Let's make that clear by
using complete() instead of complete_all().

The usage pattern of the completion is:

bcm_iproc_i2c_xfer_single_msg()
  reinit_completion()
  ...
  (activate the transfer)
  ...
  wait_for_completion_timeout()

Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
Acked-by: Ray Jui <ray.jui@broadcom.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

parent 434f14e7

drivers/i2c/busses/i2c-bcm-iproc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -158,7 +158,7 @@ static irqreturn_t bcm_iproc_i2c_isr(int irq, void *data)

		if (status & BIT(IS_M_START_BUSY_SHIFT)) {
		iproc_i2c->xfer_is_done = 1;
		complete_all(&iproc_i2c->done);
		complete(&iproc_i2c->done);
		}

		writel(status, iproc_i2c->base + IS_OFFSET);