Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8cb68c83 authored by Daniel Vetter's avatar Daniel Vetter
Browse files

drm: Fix get_property logic fumble 



Yet again I've proven that I can't negate conditions :(

Testcase: igt/kms_properties/get_property-sanity
Reviewed-by: default avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reviewed-by: default avatarSean Paul <seanpaul@chromium.org>
Fixes: eb8eb02e ("drm: Drop modeset_lock_all from the getproperty ioctl")
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Sean Paul <seanpaul@chromium.org>
Reported-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170410115445.13829-1-daniel.vetter@ffwll.ch
parent 6ce2ca58

drivers/gpu/drm/drm_property.c

+1 −1
Original line number Diff line number Diff line
@@ -476,7 +476,7 @@ int drm_mode_getproperty_ioctl(struct drm_device *dev, 
	    drm_property_type_is(property, DRM_MODE_PROP_BITMASK)) {

		list_for_each_entry(prop_enum, &property->enum_list, head) {

			enum_count++;

			if (out_resp->count_enum_blobs <= enum_count)

			if (out_resp->count_enum_blobs < enum_count)

				continue;



			if (copy_to_user(&enum_ptr[copied].value,