Commit 8c7f5f58 authored May 23, 2013 by Lars-Peter Clausen Committed by Dmitry Torokhov May 23, 2013

Input: pxa27x_keypad - pass correct pointer to free_irq()



free_irq() expects the same pointer that was passed to request_irq(),
otherwise the IRQ is not freed.

The issue was found using the following coccinelle script:

<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)

@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)

@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent d7ecfff1

drivers/input/keyboard/pxa27x_keypad.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -582,7 +582,7 @@ static int pxa27x_keypad_probe(struct platform_device *pdev)
		return 0;

		failed_free_irq:
		free_irq(irq, pdev);
		free_irq(irq, keypad);
		failed_put_clk:
		clk_put(keypad->clk);
		failed_free_io:
		@@ -600,7 +600,7 @@ static int pxa27x_keypad_remove(struct platform_device *pdev)
		struct pxa27x_keypad *keypad = platform_get_drvdata(pdev);
		struct resource *res;

		free_irq(keypad->irq, pdev);
		free_irq(keypad->irq, keypad);
		clk_put(keypad->clk);

		input_unregister_device(keypad->input_dev);