Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8c7c19a5 authored by Xin Long's avatar Xin Long Committed by David S. Miller
Browse files

sctp: do not mark sk dumped when inet_sctp_diag_fill returns err 



sctp_diag would not actually dump out sk/asoc if inet_sctp_diag_fill
returns err, in which case it shouldn't mark sk dumped by setting
cb->args[3] as 1 in sctp_sock_dump().

Otherwise, it could cause some asocs to have no parent's sk dumped
in 'ss --sctp'.

So this patch is to not set cb->args[3] when inet_sctp_diag_fill()
returns err in sctp_sock_dump().

Fixes: 8f840e47 ("sctp: add the sctp_diag.c file")
Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
Acked-by: default avatarMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: default avatarNeil Horman <nhorman@tuxdriver.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d25adbeb

net/sctp/sctp_diag.c

+0 −1
Original line number Diff line number Diff line
@@ -309,7 +309,6 @@ static int sctp_sock_dump(struct sctp_transport *tsp, void *p) 
					cb->nlh->nlmsg_seq,

					NLM_F_MULTI, cb->nlh,

					commp->net_admin) < 0) {

			cb->args[3] = 1;

			err = 1;

			goto release;

		}