Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8ad3be1e authored by Rickard Strandqvist's avatar Rickard Strandqvist Committed by Matthew Garrett
Browse files

platform: x86: asus-wmi.c: Cleaning up uninitialized variables 



There is a risk that the variable will be used without being initialized.

This was largely found by using a static code analysis program called cppcheck.

Signed-off-by: default avatarRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: default avatarMatthew Garrett <matthew.garrett@nebula.com>
parent 14627e36

drivers/platform/x86/asus-wmi.c

+1 −3
Original line number Original line Diff line number Diff line
@@ -266,7 +266,7 @@ static int asus_wmi_evaluate_method(u32 method_id, u32 arg0, u32 arg1, 
	struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL };

	struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL };

	acpi_status status;

	acpi_status status;

	union acpi_object *obj;

	union acpi_object *obj;

	u32 tmp;

	u32 tmp = 0;





	status = wmi_evaluate_method(ASUS_WMI_MGMT_GUID, 1, method_id,

	status = wmi_evaluate_method(ASUS_WMI_MGMT_GUID, 1, method_id,

				     &input, &output);

				     &input, &output);
@@ -277,8 +277,6 @@ static int asus_wmi_evaluate_method(u32 method_id, u32 arg0, u32 arg1, 
	obj = (union acpi_object *)output.pointer;

	obj = (union acpi_object *)output.pointer;

	if (obj && obj->type == ACPI_TYPE_INTEGER)

	if (obj && obj->type == ACPI_TYPE_INTEGER)

		tmp = (u32) obj->integer.value;

		tmp = (u32) obj->integer.value;

	else

		tmp = 0;





	if (retval)

	if (retval)

		*retval = tmp;

		*retval = tmp;