Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8aad6f14 authored by robert.foss@collabora.com's avatar robert.foss@collabora.com Committed by David S. Miller
Browse files

qed: Fix copy of uninitialized memory 



In qed_ll2_start_ooo() the ll2_info variable is uninitialized and then
passed to qed_ll2_acquire_connection() where it is copied into a new
memory space.

This shouldn't cause any issue as long as non of the copied memory is
every read.
But the potential for a bug being introduced by reading this memory
is real.

Detected by CoverityScan, CID#1399632 ("Uninitialized scalar variable")

Signed-off-by: default avatarRobert Foss <robert.foss@collabora.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c021aaca

drivers/net/ethernet/qlogic/qed/qed_ll2.c

+1 −1
Original line number Diff line number Diff line
@@ -968,7 +968,7 @@ static int qed_ll2_start_ooo(struct qed_dev *cdev, 
{

	struct qed_hwfn *hwfn = QED_LEADING_HWFN(cdev);

	u8 *handle = &hwfn->pf_params.iscsi_pf_params.ll2_ooo_queue_id;

	struct qed_ll2_conn ll2_info;

	struct qed_ll2_conn ll2_info = { 0 };

	int rc;



	ll2_info.conn_type = QED_LL2_TYPE_ISCSI_OOO;