Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8a8a894e authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by David S. Miller
Browse files

wimax: usb-tx: mark expected switch fall-through 



In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Notice that in this particular case, I placed the "fall through"
annotation at the bottom of the case, which is what GCC is expecting
to find.

Addresses-Coverity-ID: 115075 ("Missing break in switch")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 84906307

drivers/net/wimax/i2400m/usb-tx.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -131,12 +131,12 @@ int i2400mu_tx(struct i2400mu *i2400mu, struct i2400m_msg_hdr *tx_msg, 
			dev_err(dev, "BM-CMD: too many stalls in "

			dev_err(dev, "BM-CMD: too many stalls in "

				"URB; resetting device\n");

				"URB; resetting device\n");

			usb_queue_reset_device(i2400mu->usb_iface);

			usb_queue_reset_device(i2400mu->usb_iface);

			/* fallthrough */

		} else {

		} else {

			usb_clear_halt(i2400mu->usb_dev, usb_pipe);

			usb_clear_halt(i2400mu->usb_dev, usb_pipe);

			msleep(10);	/* give the device some time */

			msleep(10);	/* give the device some time */

			goto retry;

			goto retry;

		}

		}

		/* fall through */

	case -EINVAL:			/* while removing driver */

	case -EINVAL:			/* while removing driver */

	case -ENODEV:			/* dev disconnect ... */

	case -ENODEV:			/* dev disconnect ... */

	case -ENOENT:			/* just ignore it */

	case -ENOENT:			/* just ignore it */