Commit 8a7d656f authored Dec 10, 2015 by Filipe Manana

Btrfs: fix transaction handle leak in balance



If we fail to allocate a new data chunk, we were jumping to the error path
without release the transaction handle we got before. Fix this by always
releasing it before doing the jump.

Fixes: 2c9fe835 ("btrfs: Fix lost-data-profile caused by balance bg")
Signed-off-by: Filipe Manana <fdmanana@suse.com>

parent 348a0013

fs/btrfs/volumes.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -3548,12 +3548,11 @@ static int __btrfs_balance(struct btrfs_fs_info *fs_info)

		ret = btrfs_force_chunk_alloc(trans, chunk_root,
		BTRFS_BLOCK_GROUP_DATA);
		btrfs_end_transaction(trans, chunk_root);
		if (ret < 0) {
		mutex_unlock(&fs_info->delete_unused_bgs_mutex);
		goto error;
		}

		btrfs_end_transaction(trans, chunk_root);
		chunk_reserved = 1;
		}