Commit 896e5188 authored May 31, 2018 by Johan Hovold Committed by Felipe Balbi Jun 18, 2018

usb: dwc3: of-simple: fix use-after-free on remove



The clocks have already been explicitly disabled and put as part of
remove() so the runtime suspend callback must not be run when balancing
the runtime PM usage count before returning.

Fixes: 16adc674 ("usb: dwc3: add generic OF glue layer")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

parent 1ffba905

drivers/usb/dwc3/dwc3-of-simple.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -165,8 +165,9 @@ static int dwc3_of_simple_remove(struct platform_device *pdev)

		reset_control_put(simple->resets);

		pm_runtime_put_sync(dev);
		pm_runtime_disable(dev);
		pm_runtime_put_noidle(dev);
		pm_runtime_set_suspended(dev);

		return 0;
		}