Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 889c5580 authored by Julia Lawall's avatar Julia Lawall Committed by Jonathan Cameron
Browse files

iio: fix error return code 

Convert a zero return value on error to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent d7b79519

drivers/iio/adc/xilinx-xadc-core.c

+6 −2
Original line number Diff line number Diff line
@@ -1201,13 +1201,17 @@ static int xadc_probe(struct platform_device *pdev) 
			goto err_device_free;



		xadc->convst_trigger = xadc_alloc_trigger(indio_dev, "convst");

		if (IS_ERR(xadc->convst_trigger))

		if (IS_ERR(xadc->convst_trigger)) {

			ret = PTR_ERR(xadc->convst_trigger);

			goto err_triggered_buffer_cleanup;

		}

		xadc->samplerate_trigger = xadc_alloc_trigger(indio_dev,

			"samplerate");

		if (IS_ERR(xadc->samplerate_trigger))

		if (IS_ERR(xadc->samplerate_trigger)) {

			ret = PTR_ERR(xadc->samplerate_trigger);

			goto err_free_convst_trigger;

		}

	}



	xadc->clk = devm_clk_get(&pdev->dev, NULL);

	if (IS_ERR(xadc->clk)) {