Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 885e542c authored by Dietmar Eggemann's avatar Dietmar Eggemann Committed by Ingo Molnar
Browse files

sched/fair: Fix comment in calculate_imbalance() 



The comment in calculate_imbalance() was introduced in commit:

 2dd73a4f ("[PATCH] sched: implement smpnice")

which described the logic as it was then, but a later commit:

  b1885550 ("sched/balancing: Fix 'local->avg_load > sds->avg_load' case in calculate_imbalance()")

.. complicated this logic some more so that the comment does not match anymore.

Update the comment to match the code.

Signed-off-by: default avatarDietmar Eggemann <dietmar.eggemann@arm.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Morten Rasmussen <morten.rasmussen@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1461958364-675-3-git-send-email-dietmar.eggemann@arm.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 0a9b23ce

kernel/sched/fair.c

+4 −3
Original line number Diff line number Diff line
@@ -7000,9 +7000,10 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s 
	}



	/*

	 * In the presence of smp nice balancing, certain scenarios can have

	 * max load less than avg load(as we skip the groups at or below

	 * its cpu_capacity, while calculating max_load..)

	 * Avg load of busiest sg can be less and avg load of local sg can

	 * be greater than avg load across all sgs of sd because avg load

	 * factors in sg capacity and sgs with smaller group_type are

	 * skipped when updating the busiest sg:

	 */

	if (busiest->avg_load <= sds->avg_load ||

	    local->avg_load >= sds->avg_load) {