Commit 87aae50a authored Nov 15, 2017 by Colin Ian King Committed by Herbert Xu Nov 29, 2017

crypto: cavium - fix memory leak on info



The object info is being leaked on an error return path, fix this
by setting ret to -ENOMEM and exiting via the request_cleanup path
that will free info.

Detected by CoverityScan, CID#1408439 ("Resource Leak")

Fixes: c694b233 ("crypto: cavium - Add the Virtual Function driver for CPT")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent c9683276

drivers/crypto/cavium/cpt/cptvf_reqmanager.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -459,7 +459,8 @@ int process_request(struct cpt_vf cptvf, struct cpt_request_info req)
		info->completion_addr = kzalloc(sizeof(union cpt_res_s), GFP_KERNEL);
		if (unlikely(!info->completion_addr)) {
		dev_err(&pdev->dev, "Unable to allocate memory for completion_addr\n");
		return -ENOMEM;
		ret = -ENOMEM;
		goto request_cleanup;
		}

		result = (union cpt_res_s *)info->completion_addr;