Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 86c92ee3 authored by Emil Goode's avatar Emil Goode Committed by David S. Miller
Browse files

stmmac: Remove spin_lock call in stmmac_get_pauseparam() 



The following patch removed unnecessary spin_lock/unlock calls
in ethtool_ops callback functions. In the second and final version
of the patch one spin_lock call was left behind.

commit cab6715c
Author: Yang Wei <Wei.Yang@windriver.com>
Date:   Sun May 25 09:53:44 2014 +0800

    net: driver: stmicro: Remove some useless the lock protection

This introduced the following sparse warning:

drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:424:1: warning:
	context imbalance in 'stmmac_get_pauseparam' -
	different lock contexts for basic block

Signed-off-by: default avatarEmil Goode <emilgoode@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2f91abd4

drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c

+0 −2
Original line number Diff line number Diff line
@@ -429,8 +429,6 @@ stmmac_get_pauseparam(struct net_device *netdev, 
	if (priv->pcs)	/* FIXME */

		return;



	spin_lock(&priv->lock);



	pause->rx_pause = 0;

	pause->tx_pause = 0;

	pause->autoneg = priv->phydev->autoneg;