Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 856c634d authored by Wei Yongjun's avatar Wei Yongjun Committed by Greg Kroah-Hartman
Browse files

firmware: Google VPD: Fix return value check in vpd_platform_init() 



In case of error, the function platform_device_register_simple()
returns ERR_PTR() and never returns NULL. The NULL test in the
return value check should be replaced with IS_ERR().

Fixes: 049a59db ("firmware: Google VPD sysfs driver")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f563dab4

drivers/firmware/google/vpd.c

+2 −2
Original line number Diff line number Diff line
@@ -303,8 +303,8 @@ static int __init vpd_platform_init(void) 
	struct platform_device *pdev;



	pdev = platform_device_register_simple("vpd", -1, NULL, 0);

	if (!pdev)

		return -ENODEV;

	if (IS_ERR(pdev))

		return PTR_ERR(pdev);



	vpd_kobj = kobject_create_and_add("vpd", firmware_kobj);

	if (!vpd_kobj)