Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 84c62fb9 authored by Markus Elfring's avatar Markus Elfring Committed by Mauro Carvalho Chehab
Browse files

media: meye: Adjust two function calls together with a variable assignment 



The script "checkpatch.pl" pointed information out like the following.

ERROR: do not use assignment in if condition

Thus fix the affected source code places.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarHans Verkuil <hansverk@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 601b1f0a

drivers/media/pci/meye/meye.c

+4 −3
Original line number Diff line number Diff line
@@ -1642,14 +1642,15 @@ static int meye_probe(struct pci_dev *pcidev, const struct pci_device_id *ent) 
	meye.vdev = meye_template;

	meye.vdev.v4l2_dev = &meye.v4l2_dev;



	ret = -EIO;

	if ((ret = sony_pic_camera_command(SONY_PIC_COMMAND_SETCAMERA, 1))) {

	ret = sony_pic_camera_command(SONY_PIC_COMMAND_SETCAMERA, 1);

	if (ret) {

		v4l2_err(v4l2_dev, "meye: unable to power on the camera\n");

		v4l2_err(v4l2_dev, "meye: did you enable the camera in sonypi using the module options ?\n");

		goto outsonypienable;

	}



	if ((ret = pci_enable_device(meye.mchip_dev))) {

	ret = pci_enable_device(meye.mchip_dev);

	if (ret) {

		v4l2_err(v4l2_dev, "meye: pci_enable_device failed\n");

		goto outenabledev;

	}