Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83f1261f authored by NeilBrown's avatar NeilBrown Committed by Shaohua Li
Browse files

md/raid10: fix refounct imbalance when resyncing an array with a replacement device. 



If you have a raid10 with a replacement device that is resyncing -
e.g. after a crash before the replacement was complete - the write to
the replacement will increment nr_pending on the wrong device, which
will lead to strangeness.

Signed-off-by: default avatarNeilBrown <neilb@suse.com>
Signed-off-by: default avatarShaohua Li <shli@fb.com>
parent 414e6b9a

drivers/md/raid10.c

+1 −1
Original line number Diff line number Diff line
@@ -3229,7 +3229,7 @@ static sector_t raid10_sync_request(struct mddev *mddev, sector_t sector_nr, 
			bio->bi_error = -EIO;



			sector = r10_bio->devs[i].addr;

			atomic_inc(&conf->mirrors[d].rdev->nr_pending);

			atomic_inc(&conf->mirrors[d].replacement->nr_pending);

			bio->bi_next = biolist;

			biolist = bio;

			bio->bi_private = r10_bio;