Commit 8333eb15 authored Jan 09, 2017 by Christophe JAILLET Committed by Greg Kroah-Hartman Jan 25, 2017

w1: omap_hdq: Free resources on error path



In case of error returned by '_omap_hdq_reset()', free resources as done
elsewhere in this function.

This patch slighly changes the semantic of the code. It now propagates the
error code returned by '_omap_hdq_reset()' instead of returning -EINVAL
unconditionally.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 27a7e2a7

drivers/w1/masters/omap_hdq.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -715,7 +715,7 @@ static int omap_hdq_probe(struct platform_device *pdev)
		ret = _omap_hdq_reset(hdq_data);
		if (ret) {
		dev_dbg(&pdev->dev, "reset failed\n");
		return -EINVAL;
		goto err_irq;
		}

		rev = hdq_reg_in(hdq_data, OMAP_HDQ_REVISION);