Commit 8328ad0f authored Feb 06, 2018 by Gustavo A. R. Silva Committed by Mauro Carvalho Chehab Feb 26, 2018

media: rockchip/rga: use 64-bit arithmetic instead of 32-bit



Cast p to dma_addr_t in order to avoid a potential integer overflow.
This variable is being used in a context that expects an expression
of type dma_addr_t (u64).

The expression p << PAGE_SHIFT is currently being evaluated
using 32-bit arithmetic.

Addresses-Coverity-ID: 1458347 ("Unintentional integer overflow")

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

parent 07837433

drivers/media/platform/rockchip/rga/rga-buf.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -140,7 +140,8 @@ void rga_buf_map(struct vb2_buffer *vb)
		address = sg_phys(sgl);

		for (p = 0; p < len; p++) {
		dma_addr_t phys = address + (p << PAGE_SHIFT);
		dma_addr_t phys = address +
		((dma_addr_t)p << PAGE_SHIFT);

		pages[mapped_size + p] = phys;
		}