Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 82e68f7f authored by Willy Tarreau's avatar Willy Tarreau Committed by Linus Torvalds
Browse files

sound: ensure device number is valid in snd_seq_oss_synth_make_info 



snd_seq_oss_synth_make_info() incorrectly reports information
to userspace without first checking for the validity of the
device number, leading to possible information leak (CVE-2008-3272).

Reported-By: default avatarTobias Klein <tk@trapkit.de>
Acked-and-tested-by: default avatarTakashi Iwai <tiwai@suse.de>
Cc: stable@kernel.org
Signed-off-by: default avatarWilly Tarreau <w@1wt.eu>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 82248a5e

sound/core/seq/oss/seq_oss_synth.c

+3 −0
Original line number Diff line number Diff line
@@ -604,6 +604,9 @@ snd_seq_oss_synth_make_info(struct seq_oss_devinfo *dp, int dev, struct synth_in 
{

	struct seq_oss_synth *rec;



	if (dev < 0 || dev >= dp->max_synthdev)

		return -ENXIO;



	if (dp->synths[dev].is_midi) {

		struct midi_info minf;

		snd_seq_oss_midi_make_info(dp, dp->synths[dev].midi_mapped, &minf);