Commit 82837370 authored Oct 12, 2017 by Jakub Kicinski Committed by David S. Miller Oct 14, 2017

nfp: bpf: add missing return in jne_imm optimization



We optimize comparisons to immediate 0 as if (reg.lo | reg.hi).
The early return statement was missing, however, which means we
would generate two comparisons - optimized one followed by a
normal 2x 32 bit compare.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent bc8c80a8

drivers/net/ethernet/netronome/nfp/bpf/jit.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1191,6 +1191,7 @@ static int jne_imm(struct nfp_prog nfp_prog, struct nfp_insn_meta meta)
		emit_alu(nfp_prog, reg_none(), reg_a(insn->dst_reg * 2),
		ALU_OP_OR, reg_b(insn->dst_reg * 2 + 1));
		emit_br(nfp_prog, BR_BNE, insn->off, 0);
		return 0;
		}

		tmp_reg = ur_load_imm_any(nfp_prog, imm & ~0U, imm_b(nfp_prog));