Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 8250e6ca authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Maxime Ripard
Browse files

drm/sun4i: hdmi: Fix an error handling path in 'sun4i_hdmi_bind()' 



If we can not allocate the HDMI encoder regmap, we still need to free some
resources before returning.

Fixes: 4b1c924b ("drm/sun4i: hdmi: create a regmap for later use")
Reviewed-by: default avatarChen-Yu Tsai <wens@csie.org>
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarMaxime Ripard <maxime.ripard@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/14c42391e1b562c7495bda6ad6fa1d24ec8dc052.1521413031.git.christophe.jaillet@wanadoo.fr
parent 9ca86149

drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c

+2 −1
Original line number Diff line number Diff line
@@ -538,7 +538,8 @@ static int sun4i_hdmi_bind(struct device *dev, struct device *master, 
					     &sun4i_hdmi_regmap_config);

	if (IS_ERR(hdmi->regmap)) {

		dev_err(dev, "Couldn't create HDMI encoder regmap\n");

		return PTR_ERR(hdmi->regmap);

		ret = PTR_ERR(hdmi->regmap);

		goto err_disable_mod_clk;

	}



	ret = sun4i_tmds_create(hdmi);