Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 820351f0 authored by Al Viro's avatar Al Viro
Browse files

rsxx: don't open-code memdup_user() 



Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 8ed6010d

drivers/block/rsxx/core.c

+4 −7
Original line number Diff line number Diff line
@@ -203,14 +203,11 @@ static ssize_t rsxx_cram_write(struct file *fp, const char __user *ubuf, 
	char *buf;

	ssize_t st;



	buf = kzalloc(cnt, GFP_KERNEL);

	if (!buf)

		return -ENOMEM;

	buf = memdup_user(ubuf, cnt);

	if (IS_ERR(buf))

		return PTR_ERR(buf);



	st = copy_from_user(buf, ubuf, cnt);

	if (!st)

		st = rsxx_creg_write(card, CREG_ADD_CRAM + (u32)*ppos, cnt,

				     buf, 1);

	st = rsxx_creg_write(card, CREG_ADD_CRAM + (u32)*ppos, cnt, buf, 1);

	kfree(buf);

	if (st)

		return st;