Commit 7fbdea32 authored Sep 23, 2009 by Wu Fengguang Committed by Jens Axboe Sep 25, 2009

writeback: kupdate writeback shall not stop when more io is possible



Fix the kupdate case, which disregards wbc.more_io and stop writeback
prematurely even when there are more inodes to be synced.

wbc.more_io should always be respected.

Also remove the pages_skipped check. It will set when some page(s) of some
inode(s) cannot be written for now. Such inodes will be delayed for a while.
This variable has nothing to do with whether there are other writeable inodes.

CC: Jan Kara <jack@suse.cz>
CC: Dave Chinner <david@fromorbit.com>
CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>

parent d3ddec76

fs/fs-writeback.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -753,8 +753,8 @@ static long wb_writeback(struct bdi_writeback *wb,
	/*		/*
	* If we ran out of stuff to write, bail unless more_io got set		* If we ran out of stuff to write, bail unless more_io got set
	*/		*/
	if (wbc.nr_to_write > 0 \|\| wbc.pages_skipped > 0) {		if (wbc.nr_to_write > 0) {
	if (wbc.more_io && !wbc.for_kupdate) {		if (wbc.more_io) {
	if (wbc.nr_to_write < MAX_WRITEBACK_PAGES)		if (wbc.nr_to_write < MAX_WRITEBACK_PAGES)
	continue;		continue;
	/*		/*