Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7fba1bcd authored by Cliff Wickman's avatar Cliff Wickman Committed by Ingo Molnar
Browse files

x86, UV: Correct BAU regular message type 



The Broadcast Assist Unit messages have a regular or retry
message type. The regular type was not being set, but needs to
be, because the lack of a message type is sometimes used to
identify an unused entry in the message queue.
Also removing some excess comments.

Signed-off-by: default avatarCliff Wickman <cpw@sgi.com>
Cc: gregkh@suse.de
LKML-Reference: <E1OJvNy-0004ak-Dy@eag09.americas.sgi.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 90cc7d94

arch/x86/kernel/tlb_uv.c

+1 −14
Original line number Diff line number Diff line
@@ -580,23 +580,10 @@ const struct cpumask *uv_flush_send_and_wait(struct bau_desc *bau_desc, 
	}

	time1 = get_cycles();

	do {

		/*

		 * Every message from any given cpu gets a unique message

		 * sequence number. But retries use that same number.

		 * Our message may have timed out at the destination because

		 * all sw-ack resources are in use and there is a timeout

		 * pending there.  In that case, our last send never got

		 * placed into the queue and we need to persist until it

		 * does.

		 *

		 * Make any retry a type MSG_RETRY so that the destination will

		 * free any resource held by a previous message from this cpu.

		 */

		if (try == 0) {

			/* use message type set by the caller the first time */

			bau_desc->header.msg_type = MSG_REGULAR;

			seq_number = bcp->message_number++;

		} else {

			/* use RETRY type on all the rest; same sequence */

			bau_desc->header.msg_type = MSG_RETRY;

			stat->s_retry_messages++;

		}