Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7ebe438c authored by Aishwarya Pant's avatar Aishwarya Pant Committed by Greg Kroah-Hartman
Browse files

staging: bcm2835-audio: remove anonymous field declarations 



Anonymous field declarations are error prone. This patch replaces
anonymous declarations with explicit field declarations for typedef
SERVICE_CREATION_T in vc_vchi_audio_init(..)

Signed-off-by: default avatarAishwarya Pant <aishpant@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5e4e2ef7

drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c

+10 −10
Original line number Original line Diff line number Diff line
@@ -302,16 +302,16 @@ vc_vchi_audio_init(VCHI_INSTANCE_T vchi_instance, 
	/* Open the VCHI service connections */

	/* Open the VCHI service connections */

	for (i = 0; i < num_connections; i++) {

	for (i = 0; i < num_connections; i++) {

		SERVICE_CREATION_T params = {

		SERVICE_CREATION_T params = {

			VCHI_VERSION_EX(VC_AUDIOSERV_VER, VC_AUDIOSERV_MIN_VER),

			.version		= VCHI_VERSION_EX(VC_AUDIOSERV_VER, VC_AUDIOSERV_MIN_VER),

			VC_AUDIO_SERVER_NAME, // 4cc service code

			.service_id		= VC_AUDIO_SERVER_NAME,

			vchi_connections[i], // passed in fn pointers

			.connection		= vchi_connections[i],

			0, // rx fifo size (unused)

			.rx_fifo_size		= 0,

			0, // tx fifo size (unused)

			.tx_fifo_size		= 0,

			audio_vchi_callback, // service callback

			.callback		= audio_vchi_callback,

			instance, // service callback parameter

			.callback_param		= instance,

			1, //TODO: remove VCOS_FALSE,   // unaligned bulk receives

			.want_unaligned_bulk_rx = 1, //TODO: remove VCOS_FALSE

			1, //TODO: remove VCOS_FALSE,   // unaligned bulk transmits

			.want_unaligned_bulk_tx = 1, //TODO: remove VCOS_FALSE

			0 // want crc check on bulk transfers

			.want_crc		= 0

		};

		};





		LOG_DBG("%s: about to open %i\n", __func__, i);

		LOG_DBG("%s: about to open %i\n", __func__, i);