Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7d75f32e authored by Emmanuel Grumbach's avatar Emmanuel Grumbach Committed by Luca Coelho
Browse files

iwlwifi: pcie: delete the Tx queue timer earlier upon firmware crash 



When the firmware crashes, the transmit queues can't make
any progress. This is why we stop the counter that monitor
the transmit queues' activity.
The call that notifies the error to the op_mode may take
a bit of time, so stop the timer of the transmit queues
earlier.

Signed-off-by: default avatarEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent d74a61fc

drivers/net/wireless/intel/iwlwifi/pcie/rx.c

+4 −4
Original line number Diff line number Diff line
@@ -1413,16 +1413,16 @@ static void iwl_pcie_irq_handle_error(struct iwl_trans *trans) 
		return;

	}



	/* The STATUS_FW_ERROR bit is set in this function. This must happen

	 * before we wake up the command caller, to ensure a proper cleanup. */

	iwl_trans_fw_error(trans);



	for (i = 0; i < trans->cfg->base_params->num_of_queues; i++) {

		if (!trans_pcie->txq[i])

			continue;

		del_timer(&trans_pcie->txq[i]->stuck_timer);

	}



	/* The STATUS_FW_ERROR bit is set in this function. This must happen

	 * before we wake up the command caller, to ensure a proper cleanup. */

	iwl_trans_fw_error(trans);



	clear_bit(STATUS_SYNC_HCMD_ACTIVE, &trans->status);

	wake_up(&trans_pcie->wait_command_queue);

}