Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7d2dddda authored by Jingoo Han's avatar Jingoo Han Committed by Rusty Russell
Browse files

virtio: pci: remove unnecessary pci_set_drvdata() 



The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
parent af91706d

drivers/virtio/virtio_pci.c

+0 −2
Original line number Diff line number Diff line
@@ -742,7 +742,6 @@ static int virtio_pci_probe(struct pci_dev *pci_dev, 
	return 0;



out_set_drvdata:

	pci_set_drvdata(pci_dev, NULL);

	pci_iounmap(pci_dev, vp_dev->ioaddr);

out_req_regions:

	pci_release_regions(pci_dev);
@@ -760,7 +759,6 @@ static void virtio_pci_remove(struct pci_dev *pci_dev) 
	unregister_virtio_device(&vp_dev->vdev);



	vp_del_vqs(&vp_dev->vdev);

	pci_set_drvdata(pci_dev, NULL);

	pci_iounmap(pci_dev, vp_dev->ioaddr);

	pci_release_regions(pci_dev);

	pci_disable_device(pci_dev);