Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7ca1e11a authored by Danny Kukawka's avatar Danny Kukawka Committed by David S. Miller
Browse files

br_device: unify return value of .ndo_set_mac_address if address is invalid 



Unify return value of .ndo_set_mac_address if the given address
isn't valid. Return -EADDRNOTAVAIL as eth_mac_addr() already does
if is_valid_ether_addr() fails.

Signed-off-by: default avatarDanny Kukawka <danny.kukawka@bisect.de>
Acked-by: default avatarStephen Hemminger <shemminger@vyatta.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 15b8f4cf

net/bridge/br_device.c

+1 −1
Original line number Diff line number Diff line
@@ -167,7 +167,7 @@ static int br_set_mac_address(struct net_device *dev, void *p) 
	struct sockaddr *addr = p;



	if (!is_valid_ether_addr(addr->sa_data))

		return -EINVAL;

		return -EADDRNOTAVAIL;



	spin_lock_bh(&br->lock);

	if (compare_ether_addr(dev->dev_addr, addr->sa_data)) {