Commit 7c9989a7 authored Feb 07, 2011 by Dan Carpenter Committed by Simon Horman Feb 07, 2011

IPVS: precedence bug in ip_vs_sync_switch_mode()



'!' has higher precedence than '&'.  IP_VS_STATE_MASTER is 0x1 so
the original code is equivelent to if (!ipvs->sync_state) ...

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Hans Schillstrom <hans.schillstrom@ericsson.com>
Signed-off-by: Simon Horman <horms@verge.net.au>

parent 8525d6f8

net/netfilter/ipvs/ip_vs_sync.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -392,7 +392,7 @@ void ip_vs_sync_switch_mode(struct net *net, int mode)
		{
		struct netns_ipvs *ipvs = net_ipvs(net);

		if (!ipvs->sync_state & IP_VS_STATE_MASTER)
		if (!(ipvs->sync_state & IP_VS_STATE_MASTER))
		return;
		if (mode == ipvs->sysctl_sync_ver \|\| !ipvs->sync_buff)
		return;