Commit 7c7f1f29 authored Feb 28, 2008 by Andrew Vasquez Committed by James Bottomley Mar 03, 2008

[SCSI] qla2xxx: Correct needless clean-up resets during shutdown.



There's no point in hitting the RISC with what will most
assuredly be an unsucessful reset of the RISC hardware if the
initial stop-firmware mailbox command fails with a time-out
status.  Instead, to avoid what could amount to a lengthy
stop-firmware/detect-failure/reset-risc loop, continue with
driver unloading and discard the stop-firmware requirement.

Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

parent ba1cb461

drivers/scsi/qla2xxx/qla_init.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -4022,7 +4022,8 @@ qla2x00_try_to_stop_firmware(scsi_qla_host_t *ha)
		return;

		ret = qla2x00_stop_firmware(ha);
		for (retries = 5; ret != QLA_SUCCESS && retries ; retries--) {
		for (retries = 5; ret != QLA_SUCCESS && ret != QLA_FUNCTION_TIMEOUT &&
		retries ; retries--) {
		qla2x00_reset_chip(ha);
		if (qla2x00_chip_diag(ha) != QLA_SUCCESS)
		continue;