Commit 7c70c4f8 authored Sep 30, 2016 by Arnd Bergmann Committed by David S. Miller Oct 03, 2016

cxgb4: unexport cxgb4_dcb_enabled

A recent cleanup marked cxgb4_dcb_enabled as 'static', which is correct, but this ignored
how the symbol is also exported. In addition, the export can be compiled out when modules
are disabled, causing a harmless compiler warning in configurations for which it is not
used at all:

drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:282:12: error: 'cxgb4_dcb_enabled' defined but not used [-Werror=unused-function]

This removes the export and moves the function into the correct #ifdef so we only build
it when there are users.

Fixes: 50935857 ("cxgb4: mark symbols static where possible")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent fa34cd94

drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c

+1 −6

Original line number	Diff line number	Diff line
		@@ -277,11 +277,9 @@ static void dcb_tx_queue_prio_enable(struct net_device *dev, int enable)
		txq->dcb_prio = value;
		}
		}
		#endif /* CONFIG_CHELSIO_T4_DCB */

		static int cxgb4_dcb_enabled(const struct net_device *dev)
		{
		#ifdef CONFIG_CHELSIO_T4_DCB
		struct port_info *pi = netdev_priv(dev);

		if (!pi->dcb.enabled)
		@@ -289,11 +287,8 @@ static int cxgb4_dcb_enabled(const struct net_device *dev)

		return ((pi->dcb.state == CXGB4_DCB_STATE_FW_ALLSYNCED) \|\|
		(pi->dcb.state == CXGB4_DCB_STATE_HOST));
		#else
		return 0;
		#endif
		}
		EXPORT_SYMBOL(cxgb4_dcb_enabled);
		#endif /* CONFIG_CHELSIO_T4_DCB */

		void t4_os_link_changed(struct adapter *adapter, int port_id, int link_stat)
		{