Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7b09777c authored by Rob Herring's avatar Rob Herring Committed by Ralf Baechle
Browse files

MIPS: Add struct pci_ops member names to initialization 



Some instances of pci_ops initialization rely on the read/write members'
location in the struct. This is fragile and may break when adding new
members to the beginning of the struct.

[ralf@linux-mips.org: indent = with tabs for consistency.]

Signed-off-by: default avatarRob Herring <robh@kernel.org>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: linux-pci@vger.kernel.org
Cc: Bjorn Helgaas <bhelgaas@google.com>
Patchwork: https://patchwork.linux-mips.org/patch/8915/


Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent 250215cc

arch/mips/pci/pci-bcm1480.c

+2 −2
Original line number Diff line number Diff line
@@ -173,8 +173,8 @@ static int bcm1480_pcibios_write(struct pci_bus *bus, unsigned int devfn, 
}



struct pci_ops bcm1480_pci_ops = {

	bcm1480_pcibios_read,

	bcm1480_pcibios_write,

	.read	= bcm1480_pcibios_read,

	.write	= bcm1480_pcibios_write,

};



static struct resource bcm1480_mem_resource = {

arch/mips/pci/pci-octeon.c

+2 −2
Original line number Diff line number Diff line
@@ -327,8 +327,8 @@ static int octeon_write_config(struct pci_bus *bus, unsigned int devfn, 




static struct pci_ops octeon_pci_ops = {

	octeon_read_config,

	octeon_write_config,

	.read	= octeon_read_config,

	.write	= octeon_write_config,

};



static struct resource octeon_pci_mem_resource = {

arch/mips/pci/pcie-octeon.c

+6 −6
Original line number Diff line number Diff line
@@ -1792,8 +1792,8 @@ static int octeon_dummy_write_config(struct pci_bus *bus, unsigned int devfn, 
}



static struct pci_ops octeon_pcie0_ops = {

	octeon_pcie0_read_config,

	octeon_pcie0_write_config,

	.read	= octeon_pcie0_read_config,

	.write	= octeon_pcie0_write_config,

};



static struct resource octeon_pcie0_mem_resource = {
@@ -1813,8 +1813,8 @@ static struct pci_controller octeon_pcie0_controller = { 
};



static struct pci_ops octeon_pcie1_ops = {

	octeon_pcie1_read_config,

	octeon_pcie1_write_config,

	.read	= octeon_pcie1_read_config,

	.write	= octeon_pcie1_write_config,

};



static struct resource octeon_pcie1_mem_resource = {
@@ -1834,8 +1834,8 @@ static struct pci_controller octeon_pcie1_controller = { 
};



static struct pci_ops octeon_dummy_ops = {

	octeon_dummy_read_config,

	octeon_dummy_write_config,

	.read	= octeon_dummy_read_config,

	.write	= octeon_dummy_write_config,

};



static struct resource octeon_dummy_mem_resource = {