Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7a135a96 authored by Alex Elder's avatar Alex Elder Committed by Greg Kroah-Hartman
Browse files

greybus: loopback: use separate attribute macro for average 



Define a separate macro for displaying the average of the samples
collected.  This will be used so we can calculate the average only
when requested, rather than every time a new value gets recorded.

Signed-off-by: default avatarAlex Elder <elder@linaro.org>
Reviewed-by: default avatarBryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent 19c2a443

drivers/staging/greybus/loopback.c

+12 −1
Original line number Diff line number Diff line
@@ -100,10 +100,21 @@ static ssize_t name##_##field##_show(struct device *dev, \ 
}									\

static DEVICE_ATTR_RO(name##_##field)



#define gb_loopback_ro_avg_attr(name)					\

static ssize_t name##_avg_show(struct device *dev,			\

			    struct device_attribute *attr,		\

			    char *buf)					\

{									\

	struct gb_connection *connection = to_gb_connection(dev);	\

	struct gb_loopback *gb = connection->private;			\

	return sprintf(buf, "%llu\n", gb->name.avg);			\

}									\

static DEVICE_ATTR_RO(name##_avg)



#define gb_loopback_stats_attrs(field)					\

	gb_loopback_ro_stats_attr(field, min, u);			\

	gb_loopback_ro_stats_attr(field, max, u);			\

	gb_loopback_ro_stats_attr(field, avg, llu);

	gb_loopback_ro_avg_attr(field);



#define gb_loopback_attr(field, type)					\

static ssize_t field##_show(struct device *dev,				\