Commit 7a11370e authored Oct 15, 2014 by Michael S. Tsirkin Committed by Rusty Russell Oct 15, 2014

virtio_blk: enable VQs early



virtio spec requires drivers to set DRIVER_OK before using VQs.
This is set automatically after probe returns, virtio block violated this
rule by calling add_disk, which causes the VQ to be used directly within
probe.

To fix, call virtio_device_ready before using VQs.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

parent 4baf1e33

drivers/block/virtio_blk.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -719,6 +719,8 @@ static int virtblk_probe(struct virtio_device *vdev)
		if (!err && opt_io_size)
		blk_queue_io_opt(q, blk_size * opt_io_size);

		virtio_device_ready(vdev);

		add_disk(vblk->disk);
		err = device_create_file(disk_to_dev(vblk->disk), &dev_attr_serial);
		if (err)